-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[php-laravel] Upgrade php-laravel to 7.x
#6346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[php-laravel] Upgrade php-laravel to 7.x
#6346
Conversation
|
Do I notify the technical committee by just tagging them in the PR request directly? I don't seem to be able to actually assign formal reviewers. |
|
Yes please tag them |
|
Pinging @jebentier, @mandrean, @jfastnacht, @ackintosh, @ybelenko, @renepardon for a review please! |
ybelenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for a late response. PR branch is pretty outdated, please rebase to latest master and resolve merge conflicts.
Also please update required PHP version there
openapi-generator/modules/openapi-generator/src/main/resources/php-laravel/README.md
Line 4 in 046ba7d
| * PHP 7.1.3 or newer |
and there:
openapi-generator/modules/openapi-generator/src/main/resources/php-laravel/licenseInfo.mustache
Line 4 in 046ba7d
| * PHP version 7.1.3 |
Everything else looks pretty good! 👍
modules/openapi-generator/src/main/resources/php-laravel/composer.mustache
Outdated
Show resolved
Hide resolved
|
Related issue #6522 |
php-laravel to 7.xphp-laravel to 7.x
|
@dragonmantank can you please resolve the merge conflicts when you've time? |
727bb54 to
940660a
Compare
...napi-generator/src/main/java/org/openapitools/codegen/languages/PhpLaravelServerCodegen.java
Outdated
Show resolved
Hide resolved
|
@dragonmantank I've added generation config, you can launch it with: $ bin/generate-samples.sh bin/configs/php-laravel* |
|
@dragonmantank One more thing, don't forget to delete samples folder |
9ad8ce4 to
fcec819
Compare
|
@ybelenko Most of the CI things should be cleared up now, except for CircleCI. It's complaining about one of the auto-generated files from the sample, but I'm not 100% sure what the appropriate fix is for it. Any help would be appreciated. |
|
Frankly, I don't know why |
|
I didn't check how generated Laravel server works, but I hope that @dragonmantank checked it locally with at least few API calls. Now it's time to finally merge it. |
|
Thank you! If there's anything else I can do to help make this smoother next time, let me know! |
This upgrade Laravel from 5.6 to 7.x. 5.6 is no longer supported. I updated the source code from the main laravel/laravel repository, and updated the supported files for new/missing files. I also updated the pet store examples.
See also #2562
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.