Pass body to service #6041
Merged
Pass body to service #6041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…priately based on openapi definitions
wing328
reviewed
Apr 29, 2020
| } else { | ||
| response.end(error.error || error.message); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
@YishTish thanks for the PR. I notice all the indentations are gone. Is that intentional?
Contributor
Author
|
Thanks for noticing. Will fix and update PR
…On Wed, Apr 29, 2020 at 9:57 AM William Cheng ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
modules/openapi-generator/src/main/resources/nodejs-express-server/controllers/Controller.mustache
<#6041 (comment)>
:
> +const responsePayload = payload.payload !== undefined ? payload.payload : payload;
+if (responsePayload instanceof Object) {
+response.json(responsePayload);
+} else {
+response.end(responsePayload);
+}
+}
+
+static sendError(response, error) {
+response.status(error.code || 500);
+if (error.error instanceof Object) {
+response.json(error.error);
+} else {
+response.end(error.error || error.message);
+}
+}
@YishTish <https://github.com/YishTish> thanks for the PR. I notice all
the indentations are gone. Is that intentional?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6041 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGOOLLCUP5PCYOKEDD4YP3RO7FVFANCNFSM4MQAJKWQ>
.
--
======================
Yishai Landau
C: 972-54-979-2080
T: 972-8-6333-960
E: [email protected]
|
Member
|
Please also update the samples after you've fixed the templates. Thanks. |
Member
|
@YishTish sorry for missing this PR. Just merged. Thanks again for the PR. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #4679 -> requestBody was not arriving at the Service layer
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.