[Java][client] deserialize error bodies into defined models for Jersey2 #5609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcourtine
added a commit
to bcourtine/openapi-generator
that referenced
this pull request
May 29, 2020
wing328
added a commit
that referenced
this pull request
Jun 13, 2020
* Stronger typing for http errors with Rust client. (#5609). * Error structure can be parametrized (but is still hardcoded with `serde_json::Value` in generated code). * Each API method has is own enum of functionnal errors. * Fix the missing "Debug" derivation for API error enums. * Generate models for error deserialization. * Handle several 2xx success models. * Expose new API objects, required to use the API (params, success, error structs/enums). Co-authored-by: William Cheng <[email protected]>
6 tasks
|
anything I can do to resurrect this MR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements deserialization of models for error responses (== responses that are represented by thrown
ApiException). For now this is only done for Jersey2 client.The
ApiExceptionclass got a new methodgetErrorEntitythat returns the deserialized error model when the given error code has an error model defined and the deserialization of the error payload is successful.Attempts to solve #4777 for Jersey2.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.CC @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)