Skip to content

Conversation

@jmini
Copy link
Member

@jmini jmini commented Aug 29, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Java: @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

Rest-assured: @viclovsky

Description of the PR

Fixes #3570.

This PR add the support of Jackson in addition to gson for rest-assured.

@auto-labeler
Copy link

auto-labeler bot commented Aug 29, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jmini jmini added this to the 4.1.2 milestone Aug 29, 2019
@jmini
Copy link
Member Author

jmini commented Aug 29, 2019

As suggested by @viclovsky in #3795 (review) I have updated the PR to use TypeRef instead of com.fasterxml.jackson.databind.type.TypeFactory.

Thank you a lot for the valuable feedback.

Copy link
Contributor

@viclovsky viclovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmini jmini merged commit b0549fe into OpenAPITools:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ][java rest-assured] support for jackson

2 participants