Skip to content

Conversation

@kraney
Copy link
Contributor

@kraney kraney commented Aug 14, 2019

Proposed fix for #3591

Simply wraps usage of path parameters with a call to url.QueryEscape().

@wing328
Copy link
Member

wing328 commented Aug 15, 2019

Thanks for the fix. Please update the sample by running

"./bin/go-petstore.sh"
"./bin/go-petstore-withxml.sh"

so that the CI can verify the change.

@wing328
Copy link
Member

wing328 commented Aug 16, 2019

cc Go Technical Committee: @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

@wing328 wing328 added this to the 4.1.1 milestone Aug 16, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit b83fe0c into OpenAPITools:master Aug 16, 2019
@semtexzv
Copy link
Contributor

Is there any work done to support array parameters ? Current implementation just wraps them in [] and outputs a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants