Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jun 20, 2024

based on #18973

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc
@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

@wing328 wing328 closed this Jun 20, 2024
@wing328 wing328 deleted the ziodave-patch-1 branch June 20, 2024 05:06
@wing328 wing328 restored the ziodave-patch-1 branch June 20, 2024 05:19
@wing328 wing328 reopened this Jun 20, 2024
@wing328 wing328 changed the title Ziodave patch 1 Allow to pass a str to the Python aiohttp client Jun 20, 2024
@wing328 wing328 added this to the 7.7.0 milestone Jun 20, 2024
@wing328 wing328 marked this pull request as ready for review June 20, 2024 12:48
@wing328 wing328 merged commit 1064cb6 into master Jun 23, 2024
@wing328 wing328 deleted the ziodave-patch-1 branch June 23, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants