Skip to content

Conversation

@amaechler
Copy link
Contributor

@amaechler amaechler commented Jun 18, 2024

#14909 added a new option templateResourcePath. However, the README was missing a default value for the AsciiDoc table, which caused all the properties after to be rendered wrongly (see the README.adoc and check the properties after templateResourcePath in the rendered Markdown).

This PR adds the None default (to match the existing properties).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)

@amaechler amaechler requested a review from jimschubert as a code owner June 18, 2024 21:01
@wing328 wing328 merged commit a4d43a8 into OpenAPITools:master Jun 19, 2024
@amaechler amaechler deleted the fix-readme branch June 19, 2024 13:15
@wing328 wing328 added this to the 7.7.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants