-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[typescript-fetch] Restore pre-es2017 compatibility in modelEnum template #18418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
macjohnny
merged 7 commits into
OpenAPITools:master
from
manuel-covas:typescript-fetch-pre-es2017-compatibility
May 5, 2024
Merged
[typescript-fetch] Restore pre-es2017 compatibility in modelEnum template #18418
macjohnny
merged 7 commits into
OpenAPITools:master
from
manuel-covas:typescript-fetch-pre-es2017-compatibility
May 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late
Restore pre-es2017 compatibility in modelEnum template by not using Object.values in instanceOf{{classname}} function
macjohnny
reviewed
Apr 22, 2024
|
|
||
| export function instanceOf{{classname}}(value: any): boolean { | ||
| return Object.values({{classname}}).includes(value); | ||
| for (const key in {{classname}}) |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use { and } in the if/for
macjohnny
reviewed
Apr 22, 2024
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution
please update the generated samples
bf8759c to
78a74a0
Compare
Contributor
Author
|
@macjohnny |
macjohnny
reviewed
May 3, 2024
modules/openapi-generator/src/main/resources/typescript-fetch/modelEnum.mustache
Outdated
Show resolved
Hide resolved
Co-authored-by: Esteban Gehring <[email protected]>
05eb53a to
f9ab9ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
instanceOf{{classname}}function introduced in 93b76dd makes use of the Object.values function introduced in ECMAScript 2017, thus breaking compatibility with prior versions such as ES2016 and ES2015.This PR suggests an alternate implementation for the
instanceOf{{classname}}function in themodelEnum.mustachetemplate that restores backward-compatibility.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka