[C#][Refactor] Fix nullable required property in the constructor #1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Member
|
Looks good! |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…nAPITools#1819) * add serialization test, fix nulllable reuqired * remove vs folder
This was referenced Mar 29, 2019
wing328
pushed a commit
that referenced
this pull request
Mar 30, 2019
* Added nullable-type support to CSharpClientCodegen Overrode getNullableType method Added non-nullable type varients to 'typeMapping' collection Removed nullable type shorthand from api template * Added testcase for nullable support Set Integer property to not be nullable. Expect no '?' in baseType Set String property to be nullable. Expect no '?' in baseType * Implemented changes to 'csharp' generator from PR #1819.
wing328
pushed a commit
that referenced
this pull request
Mar 30, 2019
* Added nullable support to aspnetcore server * Regenerated aspnetcore Petstore sample * Implemented changes based on #1819.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
cc @mandrean (2017/08) @jimschubert (2017/09)