Skip to content

Conversation

@MarcMil
Copy link
Contributor

@MarcMil MarcMil commented Jul 28, 2023

Previously, it was only checked for an exact equal string, which failed when there were additional options such as charset.

Fixes #16210

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

MarcMil added 2 commits July 28, 2023 12:49
Previously, it was only checked for an exact equal string, which failed when there were additional options such as charset.
@MarcMil MarcMil changed the title Support for multipart/form-data; charset="utf-8" in Java Support for multipart/form-data; charset="utf-8" in Java GSON Generator Jul 28, 2023
@wing328
Copy link
Member

wing328 commented Jul 28, 2023

LGTM. Thanks for the fix.

@wing328 wing328 merged commit adac3b1 into OpenAPITools:master Jul 28, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Java GSON client does not send multipart requests if a charset is specified

2 participants