Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jul 28, 2023

  • Add model name mapping feature to C# codegen
  • add tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

CC @OpenAPITools/generator-core-team

@wing328 wing328 marked this pull request as ready for review July 30, 2023 16:31
@wing328 wing328 requested a review from jimschubert as a code owner July 30, 2023 16:31
@wing328 wing328 merged commit 4602f18 into master Aug 2, 2023
@wing328 wing328 deleted the model-name-mappping branch August 2, 2023 02:06
tschoppi added a commit to tschoppi/openapi-generator that referenced this pull request Dec 17, 2023
The modelNameMappings were introduced with PRs OpenAPITools#16209, OpenAPITools#16234 and are
now also used in the ruby client generator.
wing328 pushed a commit that referenced this pull request Dec 18, 2023
The modelNameMappings were introduced with PRs #16209, #16234 and are
now also used in the ruby client generator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants