-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[csharp-netcore] Configure the API key in string format for HttpSigningConfiguration #15818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream fixes
update with upstream master
…tor into feature/refresh_master
regular merge code from upstream
…tor into refresh/master
Merge upstream code to master
…tor into refresh/master
pulling in the python set-item fix from master
…tor into refresh/master
pull in golang restrict read-only props changes from upstream
…tor into refresh/upstream
Pull in latest upstream code
…ul_2022 Pull latest upstream code
update using cisco m31
This reverts commit 5b945c7.
Member
|
FYI @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) |
fmoraespadtec
pushed a commit
to padteclab/openapi-generator
that referenced
this pull request
Jun 26, 2023
…ngConfiguration (OpenAPITools#15818) * added property in HttpSIgningConfiguration to accept API key in string format. * remove trailing space, update samples * updated the sample code. * Revert "updated the sample code." This reverts commit 5b945c7. * fix the sample code compilation error for split function. * updated the sample code after the split function fix. * Removed the either or check for filePath or KeyString. --------- Co-authored-by: Aanisha Mishra <[email protected]> Co-authored-by: Vikrant Balyan (vvb) <[email protected]> Co-authored-by: Vikrant Balyan <[email protected]> Co-authored-by: Sebastien Rosset <[email protected]> Co-authored-by: William Cheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the HttpSigningConfiguration object only accepts the API key in PEM/txt file format. However, if we need to retrieve the API key from a vault or another tool in string format, it is not possible to use it directly without saving it to a file.
To address this limitation, a pull request (PR) has been made to introduce a new property called KeyString. This property allows the user to provide the API key as a string. As a result, users now have the flexibility to either provide the API key file path using the existing parameter "KeyFilePath" or provide it as a string using the newly exposed property "KeyString".
Here is the example of API key as string.
Here is the sample code for API key file path
PR checklist
Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
In case you are adding a new generator, run the following additional script :
Commit all changed files.
File the PR against the correct branch:
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@wing328