Skip to content

Conversation

@tiffmaelite
Copy link
Contributor

@tiffmaelite tiffmaelite commented Jun 6, 2023

Only a handful of generators support OpenID Connect, and they list it explicitly in their feature set. Therefore these remain unchanged by the current PR.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@tiffmaelite tiffmaelite force-pushed the fix/security_features_doc branch from cc045bc to f144904 Compare June 6, 2023 19:55
@tiffmaelite tiffmaelite force-pushed the fix/security_features_doc branch from f144904 to 32a60c7 Compare June 6, 2023 19:56
@tiffmaelite tiffmaelite changed the title fix security features listed in documentation - remove openID Connect by default fix security features listed in documentation - remove openID Connect included by default Jun 6, 2023
@tiffmaelite tiffmaelite marked this pull request as ready for review June 9, 2023 07:17
@wing328 wing328 merged commit 5cf7ed9 into OpenAPITools:master Jun 10, 2023
@tiffmaelite tiffmaelite deleted the fix/security_features_doc branch June 12, 2023 08:12
amakrushin pushed a commit to amakrushin/openapi-generator that referenced this pull request Jun 12, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants