-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Go] Serialize readonly fields #15765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wing328
merged 4 commits into
OpenAPITools:master
from
gcatanese:go-serialize-readonly-fields
Jun 10, 2023
Merged
[Go] Serialize readonly fields #15765
wing328
merged 4 commits into
OpenAPITools:master
from
gcatanese:go-serialize-readonly-fields
Jun 10, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Contributor
Author
Member
|
thanks for the fix. can you please add a test in samples/openapi3/client/petstore/go/model_test.go to cover this issue moving forward? |
Contributor
Author
|
Sure. I have never noticed that before. When do those tests run? |
Contributor
Author
|
New test added in |
Member
|
thanks for adding the test but CI tests failed: can you please take a look when you've time? |
Contributor
Author
|
@wing328 I have fixed the test, thank you |
Member
amakrushin
pushed a commit
to amakrushin/openapi-generator
that referenced
this pull request
Jun 12, 2023
* Do not skip readOnly fields in ToMap() * Regenerate sample * Add test * Correct test
fmoraespadtec
pushed a commit
to padteclab/openapi-generator
that referenced
this pull request
Jun 26, 2023
* Do not skip readOnly fields in ToMap() * Regenerate sample * Add test * Correct test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #14335 has mistakenly removed the readOnly fields during the JSON serialization, resulting in models with missing fields.
This PR reverts those changes.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)