Skip to content

[Python] Respect access_token passed into openapi_client.Configuration call #15725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Python] Respect access_token passed into openapi_client.Configuration call #15725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1929564
Fix access_token configuration logic in python client
labrown Jun 2, 2023
2e1ac56
Remove access_token from petstore sample clients
labrown Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions modules/openapi-generator/src/main/resources/python/configuration.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,6 @@ conf = {{{packageName}}}.Configuration(
self.password = password
"""Password for HTTP basic authentication
"""
self.access_token = access_token
"""Access token
"""
Copy link
Member

@wing328 wing328 Jun 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for oauth authentication scheme, we still need access_token. what about removing line 203-205 instead?

Copy link
Member

@wing328 wing328 Jun 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please PM me via Slack so that I can help you with the test.

{{#hasHttpSignatureMethods}}
if signing_info is not None:
signing_info.host = host
Expand All @@ -200,7 +197,7 @@ conf = {{{packageName}}}.Configuration(
{{/hasOAuthMethods}}
{{^hasOAuthMethods}}
{{#hasHttpBearerMethods}}
self.access_token = None
self.access_token = access_token
"""access token for OAuth/Bearer
"""
{{/hasHttpBearerMethods}}
Expand Down
3 changes: 0 additions & 3 deletions samples/client/echo_api/python/openapi_client/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,6 @@ def __init__(self, host=None,
self.password = password
"""Password for HTTP basic authentication
"""
self.access_token = access_token
"""Access token
"""
self.logger = {}
"""Logging Settings
"""
Expand Down
3 changes: 0 additions & 3 deletions samples/openapi3/client/petstore/python-aiohttp/petstore_api/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@ def __init__(self, host=None,
self.password = password
"""Password for HTTP basic authentication
"""
self.access_token = access_token
"""Access token
"""
if signing_info is not None:
signing_info.host = host
self.signing_info = signing_info
Expand Down
3 changes: 0 additions & 3 deletions samples/openapi3/client/petstore/python/petstore_api/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,6 @@ def __init__(self, host=None,
self.password = password
"""Password for HTTP basic authentication
"""
self.access_token = access_token
"""Access token
"""
if signing_info is not None:
signing_info.host = host
self.signing_info = signing_info
Expand Down