Skip to content

Conversation

@jprinet
Copy link
Contributor

@jprinet jprinet commented May 30, 2023

  • Use FileSystemOperations to delete output folder if Gradle Version >= 6
  • Add GenerateTaskConfigurationCacheTest test class

Fixes #15692

Please note that the FileSystemOperations has been introduced with Gradle 6.0 and this is the reason why we need to condition its usage.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)

@jprinet jprinet requested a review from jimschubert as a code owner May 30, 2023 13:47
Use FileSystemOperations to delete output folder if Gradle Version >= 6
@jprinet jprinet force-pushed the fix/configuration-cache-compatibility branch from ed091b5 to d446678 Compare May 30, 2023 13:57
@jprinet
Copy link
Contributor Author

jprinet commented May 31, 2023

Just realized that Gradle 5.6.1 used in the newly introduced GenerateTaskConfigurationCacheTest class is not compatible with JDK 17. Let me fix that.

@jprinet
Copy link
Contributor Author

jprinet commented May 31, 2023

I found a way but having TestNg to provide a DisabledForJreRange would have greatly helped

@jprinet jprinet force-pushed the fix/configuration-cache-compatibility branch from 5f80c36 to f440008 Compare May 31, 2023 16:32
@wing328
Copy link
Member

wing328 commented Jun 8, 2023

cc @OpenAPITools/generator-core-team

@wing328 wing328 merged commit 113cf9d into OpenAPITools:master Jun 9, 2023
amakrushin pushed a commit to amakrushin/openapi-generator that referenced this pull request Jun 12, 2023
* Allow configuration cache compatibility

Use FileSystemOperations to delete output folder if Gradle Version >= 6

* Skip Gradle legacy test if JDK is not compatible
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
* Allow configuration cache compatibility

Use FileSystemOperations to delete output folder if Gradle Version >= 6

* Skip Gradle legacy test if JDK is not compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make openapi-generator-gradle-plugin compatible with the Gradle configuration cache

3 participants