Skip to content

Conversation

@zbarbuto
Copy link
Contributor

The dart-dio generator had a couple of hard-coded /src/ paths which meant the resulting code didn't work if you used a the custom sourceFolder property as it was importing from a directory that didn't exist.

This change results in no differences in the generated code since the default source directory is already src (although a new line got added when I ran the scripts in the instructions so I've committed that) so should be non-breaking.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jun 10, 2023

cc @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

Copy link
Contributor

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to remove that empty line.

@zbarbuto zbarbuto force-pushed the fix/source-folder branch from 64a2c27 to fa5cdf5 Compare June 12, 2023 22:58
Copy link
Contributor

@ahmednfwela ahmednfwela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine , all of these files will get edited in my PR anyway after merging both dart generators

@zbarbuto zbarbuto force-pushed the fix/source-folder branch from fa5cdf5 to 7d02fcd Compare June 13, 2023 05:02
@zbarbuto
Copy link
Contributor Author

Regenerated to fix all the extra new-lines.

@wing328 wing328 merged commit e5a9081 into OpenAPITools:master Jun 13, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jun 13, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants