[resttemplate] always use @JacksonXmlElementWrapper and read xml data from referenced schema, updated #15115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Jun 8, 2023
...ttemplate-withXml/src/main/java/org/openapitools/client/model/AdditionalPropertiesClass.java
Outdated
Show resolved
Hide resolved
wing328
reviewed
Jun 8, 2023
| property.xmlName = p.getXml().getName(); | ||
| property.xmlNamespace = p.getXml().getNamespace(); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
cc @OpenAPITools/generator-core-team
Member
|
CI failure already fixed in the master. |
wing328
changed the title
amakrushin
pushed a commit
to amakrushin/openapi-generator
that referenced
this pull request
Jun 12, 2023
…d schema, updated (OpenAPITools#15115) * always use @JacksonXmlElementWrapper and read xml data from referenced schema based on OpenAPITools#5371 * run generate-samples.sh * suggestion: remove comment with empty name
fmoraespadtec
pushed a commit
to padteclab/openapi-generator
that referenced
this pull request
Jun 26, 2023
…d schema, updated (OpenAPITools#15115) * always use @JacksonXmlElementWrapper and read xml data from referenced schema based on OpenAPITools#5371 * run generate-samples.sh * suggestion: remove comment with empty name
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on @jzrebiec's commits in #5371. I mainly rebased those to the current master.
The changes can be tested e.g. with this input file, and the java-resttemplate-withXml.yaml config.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608