[Java] Replace USE_NULL_FOR_UNKNOWN_ENUM_VALUE option with nullable attribute
#1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phstudy
changed the title
USE_NULL_FOR_UNKNOWN_ENUM_VALUEUSE_NULL_FOR_UNKNOWN_ENUM_VALUE option with nullable attribute
wing328
reviewed
Oct 17, 2018
| # if you've executed sbt assembly previously it will use that instead. | ||
| export JAVA_OPTS="${JAVA_OPTS} -XX:MaxPermSize=256M -Xmx1024M -DloggerPath=conf/log4j.properties" | ||
| ags="generate -t modules/openapi-generator/src/main/resources/Java/libraries/feign -i modules/openapi-generator/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml -g java -c bin/java-petstore-feign-10x.json -o samples/client/petstore/java/feign10x -DhideGenerationTimestamp=true -DbooleanGetterPrefix=is $@" | ||
| ags="generate -t modules/openapi-generator/src/main/resources/Java/libraries/feign -i modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml -g java -c bin/java-petstore-feign-10x.json -o samples/client/petstore/java/feign10x -DhideGenerationTimestamp=true -DbooleanGetterPrefix=is $@" |
Member
There was a problem hiding this comment.
@phstudy thanks for updating the script to use OpenAPI 3.0 spec but we want to use the 2.0 spec for the scripts under ./bin/
The scripts under ./bin/openapi3 are using the 3.0 spec.
We plan to move the samples to another repository instead as llikely the size of the repo will increase significantly if we include the petstore samples for both 2.0 and 3.0 spec.
wing328
reviewed
Oct 17, 2018
| ./bin/java-petstore-retrofit2rx2.sh | ||
| ./bin/java-petstore-vertx.sh | ||
| ./bin/java-petstore-webclient.sh | ||
| ./bin/java8-petstore-jersey2.sh |
Member
There was a problem hiding this comment.
Thanks for putting the scripts in order for easier maintenance.
Member
|
I've filed #3455 to replace this PR instead. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
Replace
USE_NULL_FOR_UNKNOWN_ENUM_VALUEoption withnullableattributecc @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)