[FIX] Exported Android resources not functioning as intended

[adamschlesinger]

Changed

• Default export path for icons on Android changed to Assets/Plugins/Android/OneSignalConfig/res

Removed

• Legacy AndroidManifest from past version of imported OneSignal Android SDK

---

This change is 

[jkasten2]

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @adamschlesinger and @jkasten2)

---

com.onesignal.unity.android/Editor/SetupSteps/SetupManifestStep.cs, line 36 at r1 (raw file):

        var matches = Regex.Matches(contents, _manifestRegex);
        foreach (var match in matches) {
            if (match.ToString() != PlayerSettings.GetApplicationIdentifier(BuildTargetGroup.Android))

I believe we can remove this whole manifest step completely since we switched our Gradle release of the OneSignal-Andriod-SDK.

[adamschlesinger]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @jkasten2)

---

com.onesignal.unity.android/Editor/SetupSteps/SetupManifestStep.cs, line 36 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

I believe we can remove this whole manifest step completely since we switched our Gradle release of the OneSignal-Andriod-SDK.

I think you're right. I'll need to test it without this step to confirm.

[jkasten2]

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @adamschlesinger)

---

com.onesignal.unity.android/Editor/SetupSteps/SetupManifestStep.cs, line 36 at r1 (raw file):

Previously, adamschlesinger (Adam Schlesinger) wrote…

I think you're right. I'll need to test it without this step to confirm.

We can merge this PR in for now so it doesn't hold up the release since you tested it. We can follow up with another PR to fully remove this if it work.

[jkasten2]

Changes look good to me. Some commits could be squashed to clean up the git history though.

Reviewed 72 of 72 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @adamschlesinger)