Skip to content

Conversation

@marcoedomingos
Copy link
Contributor

@marcoedomingos marcoedomingos commented Oct 12, 2023

Description

One Line Summary

This PR provide the package namespace if the AGP is equal or higher then 8.

Details

Motivation

By adding the namespace condition for AGP 8 and higher, this fix the issue [Bug]: AGP 8 not supported #764

Testing

Manual testing

Tested during the Gradle sync with AGP 9

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@marcoedomingos
Copy link
Contributor Author

Please review: @jkasten2, @emawby.

@nan-li nan-li merged commit 8f00a35 into OneSignal:main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants