Skip to content

Avoid continuing with null message Ids #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Avoid continuing with null message Ids #1386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessageController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,10 @@ private void processInAppMessageJson(@NonNull JSONArray json) throws JSONExcepti
for (int i = 0; i < json.length(); i++) {
JSONObject messageJson = json.getJSONObject(i);
OSInAppMessage message = new OSInAppMessage(messageJson);

newMessages.add(message);
// Avoid null checks later if IAM already comes with null id
if (message.messageId != null) {
newMessages.add(message);
}
}

messages = newMessages;
Expand Down