Skip to content

Fix bug caused by System.Threading.Tasks v4.7.1 #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Fix bug caused by System.Threading.Tasks v4.7.1 #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d25ba15
Remove duplicate `JetBrains.ReSharper.CommandLineTools` package refer…
andyleejordan Oct 5, 2022
20ed43b
Bump SampleServer's `Microsoft.Extensions.Logging` package
andyleejordan Oct 5, 2022
6c695e3
Fix bug caused by `System.Threading.Tasks` v4.7.1
andyleejordan Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .build/.build.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<PackageReference Include="JetBrains.ReSharper.CommandLineTools" ExcludeAssets="All" />
<PackageReference Include="GitVersion.Tool" ExcludeAssets="All" />
<PackageReference Include="ReportGenerator" ExcludeAssets="All" />
<PackageReference Include="JetBrains.ReSharper.CommandLineTools" ExcludeAssets="All" />
Copy link
Contributor Author

@andyleejordan andyleejordan Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it was a duplicate line and the build tools complained about it. (See line 14.)

<PackageReference Include="Rocket.Surgery.Nuke" />
</ItemGroup>

Expand Down
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<PackageVersion Include="coverlet.msbuild" Version="3.1.2" />
<PackageVersion Include="System.Reactive" Version="5.0.0" />
<PackageVersion Include="System.Collections.Immutable" Version="5.0.0" />
<PackageVersion Include="System.Threading.Channels" Version="4.7.1" />
<PackageVersion Include="System.Threading.Channels" Version="6.0.0" />
<PackageVersion Include="Microsoft.Reactive.Testing" Version="5.0.0" />
<PackageVersion Include="MediatR" Version="8.1.0" />
<PackageVersion Include="Bogus" Version="34.0.2" />
Expand Down
2 changes: 1 addition & 1 deletion sample/SampleServer/SampleServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<ItemGroup>
<ProjectReference Include="../../src/Server/Server.csproj" />
<PackageReference Include="Microsoft.Extensions.Logging" VersionOverride="3.0.0" />
Copy link
Contributor Author

@andyleejordan andyleejordan Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample project was failing to restore because its dependencies updated to 6.0.0, but it was not.

<PackageReference Include="Microsoft.Extensions.Logging" VersionOverride="6.0.0" />
<PackageReference Include="Serilog.Extensions.Logging" VersionOverride="3.1.0" />
<PackageReference Include="Serilog.Sinks.File" VersionOverride="5.0.0" />
<PackageReference Include="Serilog.Sinks.Debug" VersionOverride="2.0.0" />
Expand Down