Skip to content

docs(validator): clarify circuit breaker comments to match >= conditions #15930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

docs(validator): clarify circuit breaker comments to match >= conditions #15930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions beacon-chain/rpc/prysm/v1alpha1/validator/proposer_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ func (vs *Server) circuitBreakBuilder(s primitives.Slot) (bool, error) {
return true, errors.New("no fork choicer configured")
}

// Circuit breaker is active if the missing consecutive slots greater than `MaxBuilderConsecutiveMissedSlots`.
// Circuit breaker is active if the missing consecutive slots are greater than or equal to
// `MaxBuilderConsecutiveMissedSlots`.
highestReceivedSlot := vs.ForkchoiceFetcher.HighestReceivedBlockSlot()
maxConsecutiveSkipSlotsAllowed := params.BeaconConfig().MaxBuilderConsecutiveMissedSlots
diff, err := s.SafeSubSlot(highestReceivedSlot)
Expand All @@ -66,8 +67,8 @@ func (vs *Server) circuitBreakBuilder(s primitives.Slot) (bool, error) {

if diff >= maxConsecutiveSkipSlotsAllowed {
log.WithFields(logrus.Fields{
"currentSlot": s,
"highestReceivedSlot": highestReceivedSlot,
"currentSlot": s,
"highestReceivedSlot": highestReceivedSlot,
"maxConsecutiveSkipSlotsAllowed": maxConsecutiveSkipSlotsAllowed,
}).Warn("Circuit breaker activated due to missing consecutive slot. Ignore if mev-boost is not used")
return true, nil
Expand All @@ -78,7 +79,8 @@ func (vs *Server) circuitBreakBuilder(s primitives.Slot) (bool, error) {
return false, nil
}

// Circuit breaker is active if the missing slots per epoch (rolling window) greater than `MaxBuilderEpochMissedSlots`.
// Circuit breaker is active if the missing slots per epoch (rolling window) are greater than or
// equal to `MaxBuilderEpochMissedSlots`.
receivedCount, err := vs.ForkchoiceFetcher.ReceivedBlocksLastEpoch()
if err != nil {
return true, err
Expand Down