eip7251: Bugfix and more withdrawal tests #14578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| - Fixed mesh size by appending `gParams.Dhi = gossipSubDhi` | ||
| - Fix skipping partial withdrawals count. | ||
| - wait for the async StreamEvent writer to exit before leaving the http handler, avoiding race condition panics [pr](https://github.com/prysmaticlabs/prysm/pull/14557) | ||
| - EIP7521 - fixing withdrawal bug |
There was a problem hiding this comment.
Can we be more specific with this change log? High level: what is the bug?
There was a problem hiding this comment.
It's a really minor detail, but shouldn't it be 7251 instead of 7521?
| } | ||
| if b.version >= version.Electra { | ||
| var partiallyWithdrawnBalance uint64 | ||
| for _, w := range withdrawals { |
There was a problem hiding this comment.
I think this is fine and not really worth optimizing, it's nice to read along the spec, but if you want to optimize it, we could use a map or track the length of withdrawals before entering the for loop and break at that index.
There was a problem hiding this comment.
i'm not sure if that's worth it, the withdrawals should be pretty short here
saolyn
reviewed
Oct 25, 2024
terencechain
previously approved these changes
Oct 26, 2024
|
need to update devnet 5 spec tests later |
terencechain
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
implements ethereum/consensus-specs#3979 for devnet 5
should be updated along with new spec tests.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements