Merge 1.14.0 #345
Merged
Merge 1.14.0 #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2 |
tsahee
requested changes
Aug 6, 2024
Contributor
tsahee
left a comment
tsahee
left a comment
There was a problem hiding this comment.
comment on blockchain.go
question about transaction_arg.go
amsanghi
force-pushed
the
merge-1.14.0
branch
from
3aaaa04 to
cf49bca
Compare
Re-add kilic BLS12-381 library
Remove empty Arbitrum tracing hooks
tsahee
requested changes
Oct 31, 2024
tsahee
requested changes
Nov 1, 2024
tsahee
requested changes
Nov 1, 2024
tsahee
reviewed
Nov 5, 2024
Contributor
tsahee
left a comment
tsahee
left a comment
There was a problem hiding this comment.
LGTM.
seems like nitro still has CI problems, waiting for that before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: NIT-2673
Merge upstream geth's v1.14.0 release into our geth fork:https://github.com/ethereum/go-ethereum/releases/tag/v1.14.0
nitro PR- OffchainLabs/nitro#2517
Testing done
geth and nitro tests pass