Skip to content

Refactor Limit frontend function nesting to maximum 4 levels #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 19, 2025
Merged

Refactor Limit frontend function nesting to maximum 4 levels #2671

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db72199
Refactor limit frontend function nesting to maximum 4 levels
anurag2787 Nov 17, 2025
adcd3c5
update code
anurag2787 Nov 17, 2025
d6432e8
Fixed warning
anurag2787 Nov 17, 2025
0ce1549
resolve the review
anurag2787 Nov 18, 2025
a9c219c
removed unwanted file
anurag2787 Nov 19, 2025
a60bf3f
Merge branch 'main' into refactor-function-nesting
anurag2787 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions frontend/__tests__/unit/components/ProjectTypeDashboardCard.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ import { faHeartPulse, faExclamationTriangle, faSkull } from '@fortawesome/free-
import { render, screen, fireEvent } from '@testing-library/react'
import '@testing-library/jest-dom'
import React from 'react'
import type { ProjectHealthType } from 'types/project'
import ProjectTypeDashboardCard from 'components/ProjectTypeDashboardCard'

type ProjectHealthType = 'healthy' | 'needsAttention' | 'unhealthy'

jest.mock('next/link', () => {
return function MockedLink({
children,
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/app/board/[year]/candidates/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ const BoardCandidatesPage = () => {
const renderTopActiveChannels = () => {
if (!snapshot) return null

const hasChannels =
snapshot.channelCommunications && Object.keys(snapshot.channelCommunications).length > 0

if (!hasChannels) {
if (
!snapshot.channelCommunications ||
Object.keys(snapshot.channelCommunications).length <= 0
) {
return (
<div className="mt-4 w-full">
<h4 className="mb-2 text-sm font-semibold text-gray-700 dark:text-gray-300">
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/types/project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import type { Organization } from 'types/organization'
import type { PullRequest } from 'types/pullRequest'
import type { Release } from 'types/release'

export type ProjectHealthType = 'healthy' | 'needsAttention' | 'unhealthy'

export type ProjectStats = {
contributors: number
forks: number
Expand Down
Empty file added frontend/src/utils/geolocationUtils.ts
View file
Open in desktop
Copy link
Collaborator

@ahmedxgouda ahmedxgouda Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for?

Copy link
Contributor Author

@anurag2787 anurag2787 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually another PRs file got pushed to this Sorry for inconvenience

Empty file.