-
-
Notifications
You must be signed in to change notification settings - Fork 196
test: add unit tests for GeneralCompliantComponent #2018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
addresskrish
wants to merge
5
commits into
OWASP:main
Choose a base branch
from
addresskrish:fix/issue-1835
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d1a3071
test: add unit tests for GeneralCompliantComponent
addresskrish ecb8030
fix(#1835): Refactor tests based on reviewer feedback
addresskrish b3d52a0
Merge branch 'main' into fix/issue-1835
kasya 97ea30d
Merge branch 'main' into fix/issue-1835
kasya 01ec661
Merge branch 'main' into fix/issue-1835
kasya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
73 changes: 73 additions & 0 deletions
73
frontend/__tests__/unit/components/GeneralCompliantComponent.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
import { render, screen } from '@testing-library/react'; | ||
|
||
import '@testing-library/jest-dom'; | ||
import { faCertificate } from '@fortawesome/free-solid-svg-icons'; | ||
|
||
import GeneralCompliantComponent from '../../../src/components/GeneralCompliantComponent'; | ||
|
||
type GeneralCompliantComponentProps = { | ||
compliant: boolean; | ||
icon: any; | ||
title: string; | ||
}; | ||
|
||
describe('GeneralCompliantComponent', () => { | ||
const baseProps: GeneralCompliantComponentProps = { | ||
compliant: true, | ||
icon: faCertificate, | ||
title: 'Test Title', | ||
}; | ||
|
||
it('renders successfully with minimal required props', () => { | ||
render(<GeneralCompliantComponent {...baseProps} />); | ||
expect(screen.getByText('Test Title')).toBeInTheDocument(); | ||
}); | ||
|
||
it('applies correct color for compliant=true', () => { | ||
const { container } = render(<GeneralCompliantComponent {...baseProps} compliant={true} />); | ||
const svg = container.querySelector('svg'); // Find the SVG icon | ||
expect(svg).toBeInTheDocument(); | ||
expect(svg).toHaveClass('text-green-400/80'); // Check for the specific class | ||
}); | ||
|
||
it('applies correct color for compliant=false', () => { | ||
const { container } = render(<GeneralCompliantComponent {...baseProps} compliant={false} />); | ||
const svg = container.querySelector('svg'); // Find the SVG icon | ||
expect(svg).toBeInTheDocument(); | ||
expect(svg).toHaveClass('text-red-400/80'); // Check for the specific class | ||
}); | ||
|
||
it('renders the correct icon and title', () => { | ||
render(<GeneralCompliantComponent {...baseProps} title="My Title" />); | ||
expect(screen.getByText('My Title')).toBeInTheDocument(); | ||
}); | ||
|
||
it('renders tooltip with the title', () => { | ||
const { getByText } = render(<GeneralCompliantComponent {...baseProps} title="Tooltip Title" />); | ||
// Tooltip content is rendered, but may require hover simulation in real DOM | ||
expect(getByText('Tooltip Title')).toBeInTheDocument(); | ||
}); | ||
|
||
it('handles edge case: empty title', () => { | ||
const { container } = render(<GeneralCompliantComponent {...baseProps} title="" />); | ||
expect(container).toBeInTheDocument(); | ||
}); | ||
|
||
it('has accessible role and label', () => { | ||
render(<GeneralCompliantComponent {...baseProps} />); | ||
const iconElement = screen.getByText(baseProps.title); // Asserts the title text is visible | ||
expect(iconElement).toBeInTheDocument(); | ||
// Or, if the icon has a specific role, you can check for that | ||
// expect(screen.getByRole('img', { hidden: true })).toBeInTheDocument(); | ||
}); | ||
|
||
it('renders with custom icon', () => { | ||
const customIcon = faCertificate; // Replace with another icon if needed | ||
const { container } = render(<GeneralCompliantComponent {...baseProps} icon={customIcon} />); | ||
expect(container.querySelector('svg')).toBeInTheDocument(); | ||
}); | ||
|
||
// Add more tests as needed for event handling, state, etc. | ||
}); | ||
|
||
// ...existing code... | ||
Comment on lines
+70
to
+73
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @addresskrish We totally support using AI for tests generation, but at least check what it generates and clean the code up before committing changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also should be removed