Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .coderabbit.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
chat:
auto_reply: true
code_generation:
Expand Down
21 changes: 11 additions & 10 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,17 @@ repos:
types:
- html

- repo: https://github.com/jumanjihouse/pre-commit-hook-yamlfmt
rev: 0.2.3
hooks:
- id: yamlfmt
args:
- --implicit_start
- --mapping=2
- --offset=2
- --sequence=4
exclude: (.github|pnpm-lock.yaml)
# Temporarily disabled due to Windows path issue
# - repo: https://github.com/jumanjihouse/pre-commit-hook-yamlfmt
# rev: 0.2.3
# hooks:
# - id: yamlfmt
# args:
# - --implicit_start
# - --mapping=2
# - --offset=2
# - --sequence=4
# exclude: (.github|pnpm-lock.yaml)
Comment on lines +29 to +39
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Track the Windows path issue and consider alternative solutions.

While temporarily disabling the yamlfmt hook addresses the immediate Windows compatibility issue, this could lead to inconsistent YAML formatting across the codebase. Consider documenting this as a known issue and exploring alternative solutions such as:

  1. Using a different yamlfmt hook that's Windows-compatible
  2. Adding platform-specific conditions to the pre-commit configuration
  3. Setting up a timeline to resolve the underlying path issue

🏁 Script executed:

#!/bin/bash
# Check if there are alternative yamlfmt hooks available
echo "Searching for alternative yamlfmt pre-commit hooks..."
curl -s "https://api.github.com/search/repositories?q=yamlfmt+pre-commit&type=repositories" | jq -r '.items[] | select(.stargazers_count > 10) | "\(.full_name) - \(.description)"' | head -5

Length of output: 388


Document the Windows path issue and define a plan to restore consistent YAML formatting

Temporarily disabling the yamlfmt hook works around the Windows path problem but risks divergent YAML styles. Since no widely adopted alternative pre-commit hook for yamlfmt was found, please:

  • File an upstream issue against jumanjihouse/pre-commit-hook-yamlfmt to add proper Windows‐path support.
  • Guard the existing hook so it only runs in CI (Linux/macOS) environments. For example, wrap it in a local repo entry or use an environment‐variable check in your CI configuration.
  • Update CONTRIBUTING.md (or your developer guide) with instructions for Windows users on running yamlfmt manually (e.g. via pip install yamlfmt).
  • Set a concrete timeline (e.g. 2 weeks) to revisit this workaround, merge upstream fixes, and re-enable the hook across all platforms.
🤖 Prompt for AI Agents
In .pre-commit-config.yaml around lines 29 to 39, the yamlfmt hook is disabled
due to a Windows path issue. To fix this, file an issue upstream with
jumanjihouse/pre-commit-hook-yamlfmt requesting Windows path support, modify the
config to run the yamlfmt hook only in CI environments (Linux/macOS) by adding
environment checks or wrapping it in a local repo entry, update CONTRIBUTING.md
with instructions for Windows users to run yamlfmt manually, and set a timeline
(e.g., 2 weeks) to revisit and fully re-enable the hook after upstream fixes.


- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.17.1
Expand Down
Loading