Skip to content

Conversation

@rimi-itk
Copy link
Collaborator

@rimi-itk rimi-itk commented Aug 20, 2025

Resolves #170.

Adds support for MeMo 1.2 (https://digitaliser.dk/digital-post/nyhedsarkiv/2025/mar/lancering-af-memo-version-12)

  • Requires use of https in action URLs
  • Validates MeMo filenames

Important

Notice that this pull request is sort of a hotfix release and therefore targets the master branch.

@rimi-itk rimi-itk force-pushed the feature/5189-memo-1.2 branch from ffecec3 to 7533b14 Compare August 20, 2025 08:23
@rimi-itk rimi-itk requested a review from jekuaitk August 21, 2025 13:57
@rimi-itk rimi-itk marked this pull request as ready for review August 21, 2025 13:57
@rimi-itk rimi-itk requested a review from martinyde August 21, 2025 13:57
throw new InvalidArgumentException(sprintf('Invalid type: %s. Must be one of %s.', $quote($type), implode(', ', array_map($quote, SF1601::TYPES))));
}

$meMoVersion = $options['memo-version'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave a comment explaining that if no memo-version is provided, 1.2 is the default?

@rimi-itk rimi-itk requested a review from jekuaitk August 22, 2025 09:22
@rimi-itk rimi-itk requested review from skifter and stankut August 22, 2025 11:15
Copy link
Collaborator

@stankut stankut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good overall, small question/comment from me though

@rimi-itk rimi-itk requested a review from stankut August 29, 2025 09:03
@ds-bellcom ds-bellcom added the Incl. in the next release This issue/PR is incl. in the next release label Oct 7, 2025
@ds-bellcom ds-bellcom linked an issue Oct 7, 2025 that may be closed by this pull request
5 tasks
@stankut
Copy link
Collaborator

stankut commented Oct 13, 2025

@rimi-itk hey, will you merge it?

@rimi-itk
Copy link
Collaborator Author

@rimi-itk hey, will you merge it?

Yes!

@rimi-itk rimi-itk added the Ready for merge Reviewed and approved label Oct 20, 2025
@rimi-itk rimi-itk merged commit d3e406c into OS2Forms:master Oct 20, 2025
8 checks passed
@rimi-itk rimi-itk deleted the feature/5189-memo-1.2 branch October 20, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Incl. in the next release This issue/PR is incl. in the next release Ready for merge Reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement MeMo1.2 compliance [SFRMS-129]

5 participants