Skip to content

Conversation

@opcfoundation-org
Copy link
Contributor

Updated generated files.

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.74%. Comparing base (ac05ef6) to head (6d3d99e).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3116      +/-   ##
==========================================
+ Coverage   57.48%   57.74%   +0.26%     
==========================================
  Files         357      357              
  Lines       69113    70350    +1237     
  Branches    14201    14540     +339     
==========================================
+ Hits        39729    40625     +896     
- Misses      25136    25416     +280     
- Partials     4248     4309      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newly added CallAsync overrides apparently intend to prioritize the OnCallAsync callbacks against the OnCall callbacks. If both callbacks are set than the apparent intent is not going to work and the OnCallAsync callback will be called for no reason before the OnCall callback. Shouldn't the OnCallAsync callback populate the output arguments and return the result imediatly ? Is my assumption about the priority intend wrong ?

Copy link
Contributor

@mrsuciu mrsuciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment regarding the possibility of OnCallAsync to be called unintendedly before OnCall if both are set.

@marcschier marcschier requested a review from mrsuciu July 29, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants