-
Notifications
You must be signed in to change notification settings - Fork 1k
[Client] Allow to modify sensitivity of KeepAliveStopped #3105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3105 +/- ##
==========================================
- Coverage 57.48% 57.47% -0.02%
==========================================
Files 357 357
Lines 69113 69119 +6
Branches 14201 14203 +2
==========================================
- Hits 39729 39723 -6
- Misses 25136 25146 +10
- Partials 4248 4250 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the KeepAliveStopped functionality by allowing configurable sensitivity through an interval factor and guard band, replacing the previously hardcoded values. This provides more flexibility for tuning keep-alive detection based on network conditions and application requirements.
- Replaces hardcoded guard band constant with configurable protected fields
- Modifies the KeepAliveStopped calculation to use a configurable factor and guard band
- Updates documentation to reflect the new configurable behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Libraries/Opc.Ua.Client/Session/Session.cs | Removes hardcoded constant, adds configurable fields for interval factor and guard band, updates KeepAliveStopped logic and documentation |
| Libraries/Opc.Ua.Client/Session/ISession.cs | Updates interface documentation to reflect configurable behavior |
Co-authored-by: Copilot <[email protected]>
Proposed changes
Allow to modify sensitivity of KeepAliveStopped with a factor and a guard band.
Related Issues
Types of changes
Checklist
Further comments