-
Couldn't load subscription status.
- Fork 1k
Fix XML Encoding of Null Variant to conform to spec #3062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3062 +/- ##
==========================================
+ Coverage 57.02% 57.05% +0.03%
==========================================
Files 357 357
Lines 68951 68956 +5
Branches 14156 14157 +1
==========================================
+ Hits 39317 39343 +26
+ Misses 25395 25371 -24
- Partials 4239 4242 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…aviour as ExtensionObject)
|
This PR could be problematic considering #1771 |
-> mitigated by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good..
OPCFoundation@6a1b269 OPCFoundation#3062 --------- Co-authored-by: romanett <[email protected]>
Proposed changes
Don´t write
<Null>Node if a null variant is encoded instead write<uax:Value xsi:nil=\"true\" />Related Issues
Types of changes
Checklist
Further comments