Skip to content

Conversation

@romanett
Copy link
Contributor

@romanett romanett commented Apr 22, 2025

Proposed changes

Don´t write <Null> Node if a null variant is encoded instead write <uax:Value xsi:nil=\"true\" />

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@romanett romanett self-assigned this Apr 22, 2025
@codecov
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.05%. Comparing base (d5fd96b) to head (8880220).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
+ Coverage   57.02%   57.05%   +0.03%     
==========================================
  Files         357      357              
  Lines       68951    68956       +5     
  Branches    14156    14157       +1     
==========================================
+ Hits        39317    39343      +26     
+ Misses      25395    25371      -24     
- Partials     4239     4242       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@romanett
Copy link
Contributor Author

This PR could be problematic considering #1771

@romanett
Copy link
Contributor Author

romanett commented May 2, 2025

This PR could be problematic considering #1771

-> mitigated by writing <uax:Value xsi:nil=\"true\" />

@romanett romanett added this to the 1.5.376 Maintenance Update milestone May 6, 2025
Copy link
Contributor

@mregen mregen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good..

mregen added a commit to mregen/UA-.NetStandard that referenced this pull request May 18, 2025
@mrsuciu mrsuciu merged commit 2446ce8 into OPCFoundation:master May 23, 2025
123 of 125 checks passed
@romanett romanett deleted the fixVariant branch May 23, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XML encoding of "null" Variant is incorrect

3 participants