-
Couldn't load subscription status.
- Fork 1k
[Client] Fix closing of shared Transport Channel in Recreate Scenario / Add missing event Handler to Session Constructor / Call RenewUserIdentity on Session.ReCreate #3055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…he used channel is closed when the Session.Open fails Add Missing Event Handler m_RenewUserIdentity om Session constructor taking a template
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3055 +/- ##
==========================================
+ Coverage 57.00% 57.25% +0.25%
==========================================
Files 357 357
Lines 68916 68983 +67
Branches 14154 14158 +4
==========================================
+ Hits 39285 39496 +211
+ Misses 25385 25244 -141
+ Partials 4246 4243 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Create Async open overload
Proposed changes
Some Session Methods have an overload to share an (expensive) channel between multiple session. However in some reconnect/recreate /fail to Open Session Scenario the shared transport channel is closed by the Open Mehtod of the Session. Therefore this PR Extends the Session.Open Method to select if the used Transport Channel shall be closed.
Also the Session Constructor taking a template missed to copy the m_RenewUserIdentity event handler to the new session
The Session.ReCreate(Async) Methods now also fire the RenewUserIdentity Event before Session.Open is called to refresh an expired user identity token.
Types of changes
Checklist
Further comments