Skip to content

rulesets/nixpkgs: allow reverting r-ryantm branches via UI #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025

Conversation

wolfgangwalther
Copy link
Contributor

These branches contain a / as in auto-update/re2. While ** is supposed to match /, the glob syntax is still not easy to get right.

Tested this in my fork, this works for both branches with / and without /.

Reported by @philiptaron in NixOS/nixpkgs#420319 (comment).

@infinisil can you fix this?

These branches contain a `/` as in `auto-update/re2`. While `**` is
supposed to match `/`, the glob syntax is still not easy to get right.
@wolfgangwalther wolfgangwalther requested a review from a team as a code owner July 16, 2025 19:01
Copy link

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your attention here @wolfgangwalther. Appreciate you.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, applied!

@infinisil infinisil merged commit f3a599d into NixOS:main Jul 16, 2025
2 checks passed
@wolfgangwalther wolfgangwalther deleted the nixpkgs-rulesets-create-reverts branch July 17, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants