rulesets/nixpkgs: remove exception for force push for release team #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… team Nothing in the release process documentation hints at a requirement to force push the staging branches. They should never be. https://nixos.github.io/release-wiki/Branch-Off.html
wolfgangwalther
force-pushed
the
rulesets-nixpkgs-no-force-pushes
branch
from
c49875f to
ba75447
Compare
wolfgangwalther
changed the title
|
This is not correct with how we did the last release:
I'm happy to discuss whether my option here is strange, but I think we should do that and not remove rights before that. |
|
Ah, I didn't read through the Final Release part. That's the reason for that exception, no problem with that. I'll happily drop this commit and leave it at the removal of the force push exception. |
wolfgangwalther
force-pushed
the
rulesets-nixpkgs-no-force-pushes
branch
from
ba75447 to
650775b
Compare
wolfgangwalther
changed the title
|
I documented the reason for the exception in |
infinisil
approved these changes
Jul 7, 2025
infinisil
added a commit
that referenced
this pull request
Jul 10, 2025
The rulesets were never reexported after applying #131
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have two exceptions for the @NixOS/nixos-release-managers team in the Nixpkgs branch protection rules:
They can push to release branches without Pull Requests.(valid use-case)AFAICT, neither is required for the release process documented at https://nixos.github.io/release-wiki/Branch-Off.html. Those exceptions are most likely caused by the old branch protection rules, which were not as flexible as the new rulesets.
Note: Branch creation does not require "pushing to release branches". This only applies after the branch is created and more commits should be pushed to it. I just confirmed that in my fork to be sure.