Skip to content

cargo-vendor: drop #69274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2019
Merged

cargo-vendor: drop #69274

merged 1 commit into from
Sep 23, 2019

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Sep 23, 2019

Cargo 1.37 imported cargo-vendor as built-in command [1]

[1] rust-lang/cargo#6869

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
cargo-vendor: drop
aed74e8 
Cargo 1.37 imported `cargo-vendor` as built-in command [1]

[1] rust-lang/cargo#6869
@ofborg ofborg bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 23, 2019
jonringer
jonringer approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review no re-builds :)

@Mic92 Mic92 merged commit c73c32d into NixOS:master Sep 23, 2019
erikarvstedt added a commit to erikarvstedt/nix-bitcoin that referenced this pull request Mar 4, 2020
@erikarvstedt
electrs: enable unstable build, pin pkg to unstable
f30aadb 
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
jonasnick pushed a commit to jonasnick/nix-bitcoin that referenced this pull request Mar 8, 2020
@erikarvstedt @jonasnick
electrs: enable unstable build, pin pkg to unstable
a0bb45d 
stable's buildRustPackage is painfully slow when evaluating (adds >1 sec
even on a fast machine).

This is fixed (NixOS/nixpkgs#69274) in unstable.
@marsam marsam deleted the drop-cargo-vendor branch May 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonringer jonringer jonringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marsam @jonringer @Mic92