Skip to content

[staging-next] postgresqlPackages.pgvecto-rs: fix build with rust 1.89 #435945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2025
Merged

[staging-next] postgresqlPackages.pgvecto-rs: fix build with rust 1.89 #435945

merged 1 commit into from
Aug 22, 2025

Conversation

@diogotcorreia
Copy link
Member

@diogotcorreia diogotcorreia commented Aug 22, 2025 •
edited
Loading

The dangerous_implicit_autorefs lint now causes a compile error 1, which breaks pgvecto-rs.
This commit forces the lint to only throw a warning.

Hydra failure: https://hydra.nixos.org/build/305231743

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@diogotcorreia
postgresqlPackages.pgvecto-rs: fix build with rust 1.89
3cdfa94 
The `dangerous_implicit_autorefs` lint now causes a compile error [1],
which breaks pgvecto-rs.
This commit forces the lint to only throw a warning.

[1]: rust-lang/rust#141661
@wolfgangwalther
Copy link
Contributor

Has this been reported upstream as well / is there already an issue about it?

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Aug 22, 2025 •
edited
Loading

@wolfgangwalther No, not that I can see. The upstream project seems to be "abandoned", the last commit has been 6 months ago.
Either way, we're running a version behind due to Immich (we have 0.3.0, latest is 0.4.0). Doesn't seem to be fixed on the main branch either.

EDIT: also, upstream builds with a specific (and old) version of nightly rust: https://github.com/tensorchord/pgvecto.rs/blob/v0.4.0/rust-toolchain.toml

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Aug 22, 2025
@wolfgangwalther
Copy link
Contributor

I feel we should still at least report it.

@nix-owners nix-owners bot requested review from Ma27, esclear and thoughtpolice August 22, 2025 18:36
@wolfgangwalther
Copy link
Contributor

At the same time, verification whether pgvecto.rs is actually abandoned / archived or not would be interesting. They do say:

We have a new implementation VectorChord with better stability and performance.

So maybe they really intend not to do anything about it anymore. In this case they should maybe archive the repo...

@diogotcorreia diogotcorreia mentioned this pull request Aug 22, 2025
Open
@diogotcorreia
Copy link
Member Author

Opened issue upstream: tensorchord/pgvecto.rs#651

@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 435945
Commit: 3cdfa9471c6a7884e8e9427a47dd4e7ed93cbec1

x86_64-linux

✅ 3 packages built:
  • postgresql14Packages.pgvecto-rs
  • postgresql15Packages.pgvecto-rs
  • postgresql16Packages.pgvecto-rs

aarch64-linux

✅ 3 packages built:
  • postgresql14Packages.pgvecto-rs
  • postgresql15Packages.pgvecto-rs
  • postgresql16Packages.pgvecto-rs

@wolfgangwalther wolfgangwalther merged commit 1ef56e0 into NixOS:staging-next Aug 22, 2025
28 of 31 checks passed
@diogotcorreia diogotcorreia deleted the fix/rustc-1.89-pgvecto.rs branch August 22, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

@Ma27 Ma27 Awaiting requested review from Ma27

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@esclear esclear Awaiting requested review from esclear

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diogotcorreia @wolfgangwalther