Skip to content

fix: resolve operator ambiguity in i3 foreign key check #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: resolve operator ambiguity in i3 foreign key check #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8209498
fix: resolve operator ambiguity in i3 foreign key check
NikolayS Sep 30, 2025
8d02175
test(ci): add comprehensive test for i3 foreign key check
NikolayS Sep 30, 2025
d9f648e
revert: remove type cast to demonstrate CI test failure
NikolayS Sep 30, 2025
97b7863
fix: add explicit type cast to resolve operator ambiguity in i3
NikolayS Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 37 additions & 15 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ jobs:
# Create extensions (pg_stat_statements may not work without shared_preload_libraries)
psql -h localhost -U postgres -d test -c 'CREATE EXTENSION IF NOT EXISTS pg_stat_statements;' || echo "Warning: pg_stat_statements extension not available"
psql -h localhost -U postgres -d test -c 'CREATE EXTENSION IF NOT EXISTS pgstattuple;'
psql -h localhost -U postgres -d test -c 'CREATE EXTENSION IF NOT EXISTS intarray;'
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow SQL style guide


# Create minimal privilege user for testing
psql -h localhost -U postgres -d test -c "CREATE USER dba_user;"
Expand All @@ -71,7 +72,14 @@ jobs:
# Create test tables for alignment testing (as superuser)
psql -h localhost -U postgres -d test -c "CREATE TABLE align1 AS SELECT 1::int4, 2::int8, 3::int4 AS more FROM generate_series(1, 100000) _(i);"
psql -h localhost -U postgres -d test -c "CREATE TABLE align2 AS SELECT 1::int4, 3::int4 AS more, 2::int8 FROM generate_series(1, 100000) _(i);"


# Create test tables for foreign key testing (i3 query)
psql -h localhost -U postgres -d test -c "CREATE TABLE fk_parent (id int PRIMARY KEY, data text);"
psql -h localhost -U postgres -d test -c "CREATE TABLE fk_child (id int PRIMARY KEY, parent_id int, data text, CONSTRAINT fk_test FOREIGN KEY (parent_id) REFERENCES fk_parent(id));"
psql -h localhost -U postgres -d test -c "INSERT INTO fk_parent SELECT i, 'data_' || i FROM generate_series(1, 100000) i;"
psql -h localhost -U postgres -d test -c "INSERT INTO fk_child SELECT i, (i % 100000) + 1, 'data_' || i FROM generate_series(1, 200000) i;"
psql -h localhost -U postgres -d test -c "ANALYZE;"

# Grant access to test tables for dba_user
psql -h localhost -U postgres -d test -c "GRANT SELECT ON ALL TABLES IN SCHEMA public TO dba_user;"

Expand All @@ -83,12 +91,12 @@ jobs:
echo "\set postgres_dba_wide true" > ~/.psqlrc
echo "\set postgres_dba_interactive_mode false" >> ~/.psqlrc
echo "Testing all SQL files in wide mode with minimal privileges..."
for f in sql/*; do
for f in sql/*; do
echo " Testing $f..."
if ! psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f "$f" > /dev/null 2>&1; then
if ! PAGER=cat psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f "$f" > /dev/null 2>&1; then
echo "❌ FAILED: $f in wide mode"
echo "Error output:"
psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f "$f"
PAGER=cat psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f "$f"
exit 1
fi
done
Expand All @@ -99,12 +107,12 @@ jobs:
echo "\set postgres_dba_wide false" > ~/.psqlrc
echo "\set postgres_dba_interactive_mode false" >> ~/.psqlrc
echo "Testing all SQL files in normal mode with minimal privileges..."
for f in sql/*; do
for f in sql/*; do
echo " Testing $f..."
if ! psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f "$f" > /dev/null 2>&1; then
if ! PAGER=cat psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f "$f" > /dev/null 2>&1; then
echo "❌ FAILED: $f in normal mode"
echo "Error output:"
psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f "$f"
PAGER=cat psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f "$f"
exit 1
fi
done
Expand All @@ -114,36 +122,50 @@ jobs:
run: |
echo "\set postgres_dba_wide false" > ~/.psqlrc
echo "\set postgres_dba_interactive_mode false" >> ~/.psqlrc

echo "Running regression tests with minimal privileges..."

echo " Testing 0_node.sql..."
OUTPUT=$(psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f sql/0_node.sql | grep Role)
OUTPUT=$(PAGER=cat psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f sql/0_node.sql | grep Role)
if [[ "$OUTPUT" == *"Master"* ]]; then
echo " ✓ Role test passed"
else
echo " ✗ Role test failed: $OUTPUT"
exit 1
fi

echo " Testing p1_alignment_padding.sql..."
OUTPUT=$(psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f sql/p1_alignment_padding.sql | grep align)
OUTPUT=$(PAGER=cat psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f sql/p1_alignment_padding.sql | grep align)
if [[ "$OUTPUT" == *"align1"* && "$OUTPUT" == *"align2"* && "$OUTPUT" == *"int4, more, int8"* ]]; then
echo " ✓ Alignment padding test passed"
else
echo " ✗ Alignment padding test failed: $OUTPUT"
exit 1
fi

echo " Testing a1_activity.sql..."
OUTPUT=$(psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f sql/a1_activity.sql | grep User)
OUTPUT=$(PAGER=cat psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f sql/a1_activity.sql | grep User)
if [[ "$OUTPUT" == *"User"* ]]; then
echo " ✓ Activity test passed"
else
echo " ✗ Activity test failed: $OUTPUT"
exit 1
fi


echo " Testing i3_non_indexed_fks.sql (with intarray extension)..."
OUTPUT=$(PAGER=cat psql -h localhost -U dba_user -d test --no-psqlrc -f warmup.psql -f sql/i3_non_indexed_fks.sql 2>&1)
if [[ "$OUTPUT" == *"ERROR"* ]]; then
echo " ✗ i3 test failed with error:"
echo "$OUTPUT"
exit 1
elif [[ "$OUTPUT" == *"fk_child"* && "$OUTPUT" == *"fk_test"* ]]; then
echo " ✓ i3 foreign key test passed (found foreign key without index)"
else
echo " ✗ i3 test failed: unexpected output"
echo "$OUTPUT"
exit 1
fi

echo "✅ All regression tests passed with minimal privileges"


2 changes: 1 addition & 1 deletion sql/i3_non_indexed_fks.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ with fk_actions ( code, action ) as (
join fk_cols_list using (fkoid)
left join index_list on
conrelid = indrelid
and (indkey::int2[])[0:(array_length(key_cols,1) -1)] operator(pg_catalog.@>) key_cols
and (indkey::int2[])[0:(array_length(key_cols,1) -1)] operator(pg_catalog.@>) key_cols::int2[]

), fk_perfect_match as (
select fkoid
Expand Down