fix: Handle Unicode characters in Windows user paths #846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Problem
Fixes #823
Installation stalls at 40% on Windows 11 when usernames contain non-ASCII characters (e.g., German umlauts like "ö").
Reported by: @WirelessRoth (username: Jörg)
Symptoms:
🔍 Root Cause
The code in
runner/internal/store/manager.gousedos.UserHomeDir()which returns paths likeC:\Users\Jörg. The subsequentos.MkdirAll()call failed silently with Unicode characters.✅ Solution
Replaced
os.UserHomeDir() + ".cache"withos.UserCacheDir(), which properly handles Unicode characters across all platforms.Why This Works
os.UserCacheDir()provides platform-specific cache directories:C:\Users\<username>\AppData\Local~/Library/Caches~/.cache📝 Changes
runner/internal/store/manager.goto useos.UserCacheDir()🧪 Testing
Unit Tests Added
✅ German umlauts (Jörg)
✅ French accents (François)
✅ Spanish tildes (José)
✅ Japanese characters (山田)
✅ Emoji (User😀)
🚀 Benefits
✅ Checklist