EIP-7251: Add EL triggered consolidations #7182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
Jun 23, 2024
src/Nethermind/Nethermind.Core/ConsensusRequests/ConsensusRequest.cs
Outdated
Show resolved
Hide resolved
MarekM25
approved these changes
Jun 23, 2024
rjnrohit
force-pushed
the
feature/consolidations
branch
from
0fd1e22 to
16b4477
Compare
LukaszRozmej
approved these changes
Jun 26, 2024
Member
LukaszRozmej
left a comment
LukaszRozmej
left a comment
There was a problem hiding this comment.
This can be done in next PR, but I think we should start leveraging ConsensusRequest polimorphism, so we can easily add more in the future with lesser code
| ValidateReceipts = true; | ||
|
|
||
| // The below addresses are added for all forks, but the given EIPs can be enabled at a specific timestamp or block. | ||
| Eip7251ContractAddress = Eip7251Constants.ConsolidationRequestPredeployAddress; |
Member
There was a problem hiding this comment.
@MarekM25 why are they added in Olympic, rather than fork they are enabled at? Seems messy to me.
Contributor
There was a problem hiding this comment.
becuase you don't add them for transition. You don't need to have transition to specify address. We could seperate it to fork-agnostic properties cc: @rjnrohit
src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayloadV4.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayloadBodyV2Result.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin.Test/EngineModuleTests.V4.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements : ethereum/EIPs#8625. more info at: https://eips.ethereum.org/EIPS/eip-7251 and ethereum/execution-apis#554
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?