[cancun] [eip6780] apply danno's clarification: disable eth burn on preexisting contract when inheritor equals contract address

[smartprogrammer93]

context here:
ethereum/EIPs#7308

Changes

• disable eth burn on preexisting contract when inheritor equals contract address for cancun

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Documentation

Requires documentation update

• Yes
• No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

• Yes
• No

[LukaszRozmej]

Wouldn't:

        if (!spec.SelfdestructOnlyOnSameTransaction || createInSameTx || !inheritor.Equals(executingAccount))
        {
            _state.SubtractFromBalance(executingAccount, result, spec);
        }

        return true;

be more readable?

[smartprogrammer93]

I like to specify only the condition where the burn does not happen. I find it less confusing than specifying all the conditions that it does burn.