Withdrawals wei -> gwei #5139
Merged
Withdrawals wei -> gwei #5139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Nethermind/Nethermind.Serialization.Rlp/WithdrawalDecoder.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
approved these changes
Jan 13, 2023
rubo
requested changes
Jan 15, 2023
Contributor
rubo
left a comment
rubo
left a comment
There was a problem hiding this comment.
GWei should be changed to Gwei.
src/Nethermind/Nethermind.Serialization.Rlp/WithdrawalDecoder.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Serialization.Rlp/WithdrawalDecoder.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@MarekM25 Could you please keep following our PR template? |
Contributor
Author
sure, sorry about it :) |
rubo
approved these changes
Jan 16, 2023
rubo
force-pushed
the
withdrawals_to_gwei
branch
from
e418ad5 to
1eac7f4
Compare
Contributor
|
@MarekM25 I think we can merge it as I implemented ethereum/execution-apis#337 that's based on this PR. Hive tests passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge for now.
Engine API: ethereum/execution-apis#354
EIP-4895: ethereum/EIPs#6325