Make Scalar Worker to Worker stages configurable #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were not configurable. There are cases where tuning these values can have a large impact. Made it configurable in the same pattern that the SSE sink and Keyed W2W stages are configured.
timmartin-stripe
requested review from
Andyz26,
calvin681,
dtrager02,
fdc-ntflx,
hellolittlej and
james-lubin
as code owners
Andyz26
approved these changes
Oct 13, 2025
timmartin-stripe
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Test Results152 files ±0 152 suites ±0 10m 1s ⏱️ +56s For more details on these failures, see this check. Results for commit 26fb550. ± Comparison against base commit ca9b829. |
Contributor
Author
|
@Andyz26 Is this a flaky test? I'm not sure how what I changed would impact that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were not configurable. There are cases where tuning these values can have a large impact. Made it configurable in the same pattern that the SSE sink and Keyed W2W stages are configured.
I pulled the defaults from ServerConfig to keep them consistent so that nothing changes when this is added.
Context
Explain context and other details for this pull request.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests