Fix worker no heartbeat race condition #734
Merged
+117
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andyz26
requested review from
calvin681,
fdc-ntflx,
hmitnflx and
sundargates
as code owners
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
Test Results619 tests +1 609 ✅ +1 7m 44s ⏱️ +2s Results for commit 547a26d. ± Comparison against base commit e90032d. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
sundargates
approved these changes
Dec 18, 2024
| if (!workerMeta.getLastHeartbeatAt().isPresent() || Duration.between(workerMeta.getLastHeartbeatAt().get(), currentTime).getSeconds() | ||
| > missedHeartBeatToleranceSecs) { | ||
| // heartbeat too old | ||
| // no heartbeat or heartbeat too old |
Contributor
There was a problem hiding this comment.
add this above line 1946
Andyz26
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A race condition was introduced from #731 when a heartbeat check happened between launch event and first heartbeat and can trigger NPE on the actor.
Refactored the condition check on the case above + improve UTs to cover the related states.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests