-
Notifications
You must be signed in to change notification settings - Fork 212
Make TE allocation strictly following core number #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Uploaded ArtifactsTo use these artifacts in your Gradle project, paste the following lines in your build.gradle. |
fdc-ntflx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| * @param workerId worker id of the task that's going to run on the node. | ||
| * @return task executor assigned for the particular task. | ||
| */ | ||
| CompletableFuture<TaskExecutorID> getTaskExecutorFor(MachineDefinition machineDefinition, WorkerId workerId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: What was the need to introduce a new type here?
Context
Update the allocation logic in TE so that the scheduler will only put the requested node into a TE strictly using the smallest CPU cores to avoid having TEs spreading in different container sizes. Also, introduce an intermediate allocation request contract to help eventual decoupling/removal of Mesos classes.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests