Correct the proving-capability abstraction for usage with triton-vm Proof (as opposed to TransactionProof) #603
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| #!/usr/bin/env php | ||
| <?php | ||
|
|
||
| // This script is useful for finding slow unit tests. | ||
| // | ||
| // The script sorts the output of `cargo test` by duration of | ||
| // each test, and then prints the results in descending order. | ||
| // | ||
| // It also prints stats at the bottom, eg: | ||
| // | ||
| // --- unit test stats --- | ||
| // Count: 733 | ||
| // Total: 974.801 | ||
| // Min: 0.000 | ||
| // Max: 104.073 | ||
| // Mean: 1.3298785811733 | ||
| // Median: 0.118 | ||
| // ---------------------- | ||
| // | ||
| // As of this writing, it is necessary to use the nightly compiler | ||
| // in order to obtain timing for each test. | ||
| // | ||
| // Here is example usage: | ||
| // | ||
| // cargo +nightly test -- -Z unstable-options --report-time 2>&1 | tee tests.out | ||
| // sort_tests.php tests.out | ||
|
|
||
| $file = @$argv[1]; | ||
|
|
||
| if(!$file || !file_exists($file)) { | ||
| die("please provide a file with output of cargo test, eg:\n cargo +nightly test -- -Z unstable-options --report-time 2>&1 | tee tests.out"); | ||
| } | ||
|
|
||
| $lines = file($file); | ||
|
|
||
| $a = []; | ||
| foreach($lines as $line) { | ||
| $fields = explode(' ', $line); | ||
| $key = $fields[count($fields)-1]; | ||
| $key_new = trim(str_replace(['<', '>', 's'], '', $key)); | ||
| if($key_new != $key && is_numeric($key_new) && substr($line, 0, 5) == "test " && !strstr($line, "finished in")) { | ||
| $a[$line] = $key_new; | ||
| } else { | ||
| // echo "skipping $line"; | ||
| } | ||
| } | ||
|
|
||
| arsort($a); | ||
|
|
||
| foreach($a as $line => $time) { | ||
| echo $line ; | ||
| } | ||
|
|
||
| echo "\n\n\n"; | ||
| analyze_float_array(array_values($a)); | ||
|
|
||
|
|
||
|
|
||
| function analyze_float_array(array $numbers): void { | ||
| if (empty($numbers)) { | ||
| echo "Error: The input array is empty. Cannot calculate statistics.\n"; | ||
| return; | ||
| } | ||
|
|
||
| // --- Min and Max --- | ||
| $min = min($numbers); | ||
| $max = max($numbers); | ||
|
|
||
| // --- Mean (Average) --- | ||
| $sum = array_sum($numbers); | ||
| $count = count($numbers); | ||
| $mean = $sum / $count; | ||
|
|
||
| // --- Median --- | ||
| // 1. Sort the array numerically. | ||
| sort($numbers); | ||
|
|
||
| // 2. Determine the middle index(es). | ||
| $middleIndex = floor($count / 2); | ||
|
|
||
| if ($count % 2 === 1) { | ||
| // Odd number of elements: median is the middle element. | ||
| $median = $numbers[$middleIndex]; | ||
| } else { | ||
| // Even number of elements: median is the average of the two middle elements. | ||
| $median = ($numbers[$middleIndex - 1] + $numbers[$middleIndex]) / 2; | ||
| } | ||
|
|
||
| // --- Print Results --- | ||
| echo "--- unit test stats ---\n"; | ||
| echo "Count: " . $count . "\n"; | ||
| echo "Total: " . $sum . "\n"; | ||
| echo "Min: " . $min . "\n"; | ||
| echo "Max: " . $max . "\n"; | ||
| echo "Mean: " . $mean . "\n"; | ||
| echo "Median: " . $median . "\n"; | ||
| echo "----------------------\n"; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last time I tried to install PHP to run one of the scripts in this repo, I ended up corrupting my operating system and I had to reinstall ubuntu from scratch. (It was certainly not the fault of the script I was trying to run because I had not even gotten to that point.) I am not tempted to try again to see what went wrong the first time.
This is not a vendetta against PHP. I actually think it is a fantastic language and great at what it does. But I do want to raise the question whether it is a good idea to include PHP scripts in this repository. They obviously come with a huge dependency even if the fallout of installing that dependency does not include corrupting the operating system.
Possible alternatives:
If the issue is, "who is going to write the bash/rust/python equivalent?" then I wonder how far we get with asking AI to transcribe it.
If the issue is, "who is going to maintain it?" then PHP is the most ill-suited option for random new developers. (Okay, scratch that. Bash is. But PHP is second. The point remains that rust and python are both more accessible and more popular.)