fix(data): PR review comments

Author: Depyden

src/validation/joi/joi.shared.schemas.test.ts

@@ -245,6 +245,9 @@ describe('dateTimeStringSchema', () => {
     '2024/07/25T00:55', // Invalid date separator ("/" instead of "-")
     '2024-07-25T00-55', // Invalid time separator ("-" instead of ":")
     '2024-07-25T00:55Zextra', // Extra characters after a valid datetime
+    'extra2024-07-25T00:55Z', // Extra characters before a valid datetime
+    'Some random string', // Random string
+    '2024 was a good year', // Year with some text
   ]
 
   test.each(invalidDateTimes)('invalid dateTime: %s', s => {

src/validation/joi/joi.shared.schemas.ts

@@ -29,6 +29,10 @@ export const dateIntervalStringSchema = stringSchema.regex(DATE_INTERVAL_REGEX).
   'string.pattern.base': `must be a DateInterval string`,
 })
 
+export const DATE_TIME_STRING_REGEX =
+  /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}(?::\d{2})?(?:Z|[+-]\d{2}:\d{2})?$/
+export const dateTimeStringSchema = stringSchema.regex(DATE_TIME_STRING_REGEX)
+
 /**
  * Allows all values of a String Enum.
  */
@@ -174,8 +178,3 @@ export const baseDBEntitySchema: ObjectSchema<BaseDBEntity> = objectSchema<BaseD
 export const macAddressSchema = stringSchema.regex(/^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})$/)
 
 export const uuidSchema = stringSchema.uuid()
-
-export const DATE_TIME_STRING_REGEX =
-  /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}(?::\d{2})?(?:Z|[+-]\d{2}:\d{2})?$/
-
-export const dateTimeStringSchema = stringSchema.regex(DATE_TIME_STRING_REGEX)