fix(data): Add tests + pr review fixes

Author: Depyden

src/validation/joi/joi.shared.schemas.test.ts

@@ -6,6 +6,7 @@ import {
   binarySchema,
   dateIntervalStringSchema,
   dateObjectSchema,
+  dateTimeStringSchema,
   emailSchema,
   ianaTimezoneSchema,
   idSchema,
@@ -218,3 +219,35 @@ describe('uuidSchema', () => {
     expect(() => validate('123g4567-e89b-12d3-a456-426614174000', uuidSchema)).toThrow()
   })
 })
+
+describe('dateTimeStringSchema', () => {
+  const validDateTimes = [
+    '2024-09-30T00:55',
+    '2024-09-30T00:55+02:00',
+    '2024-09-30T00:55Z',
+    '2024-09-30T00:55:12',
+    '2024-09-30T00:55:12+02:00',
+    '2024-09-30T00:55:12Z',
+  ]
+
+  test.each(validDateTimes)('valid dateTime: %s', s => {
+    expect(validate(s, dateTimeStringSchema)).toBe(s)
+  })
+
+  const invalidDateTimes = [
+    undefined, // Non-string
+    null, // Non-string
+    '', // Empty string
+    '2024-07-25', // Missing time part
+    'T00:55:12Z', // Missing date
+    '2024-07-25T0055Z', // Missing colon in time
+    '2024-07-25 00:55', // Missing "T" between date and time
+    '2024/07/25T00:55', // Invalid date separator ("/" instead of "-")
+    '2024-07-25T00-55', // Invalid time separator ("-" instead of ":")
+    '2024-07-25T00:55Zextra', // Extra characters after a valid datetime
+  ]
+
+  test.each(invalidDateTimes)('invalid dateTime: %s', s => {
+    expect(() => validate(s, dateTimeStringSchema)).toThrow()
+  })
+})

src/validation/joi/joi.shared.schemas.ts

@@ -175,5 +175,7 @@ export const macAddressSchema = stringSchema.regex(/^([0-9A-Fa-f]{2}[:-]){5}([0-
 
 export const uuidSchema = stringSchema.uuid()
 
-export const DATE_TIME_STRING_REGEX = /d{4}-\d{2}-\d{2}T\d{2}:\d{2}([+-]\d{2}:\d{2})?/
+export const DATE_TIME_STRING_REGEX =
+  /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}(?::\d{2})?(?:Z|[+-]\d{2}:\d{2})?$/
+
 export const dateTimeStringSchema = stringSchema.regex(DATE_TIME_STRING_REGEX)