Skip to content

fix: setup docs links #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2023
Merged

fix: setup docs links #5762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79b1088
fix Env Verification Message
vallemar Oct 10, 2023
8be30a4
update constant SYSTEM_REQUIREMENTS_LINKS
vallemar Oct 10, 2023
d3b0aa1
Update lib/services/platform-environment-requirements.ts
vallemar Oct 11, 2023
ab3b746
Update lib/services/platform-environment-requirements.ts
vallemar Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/services/platform-environment-requirements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,11 @@ export class PlatformEnvironmentRequirements
darwin: "macos",
} as any)[process.platform];

const anchor = platform ? `#${os}-${platform.toLowerCase()}` : "";
const anchor = platform ? `#setting-up-${os}-for-${platform.toLowerCase()}` : "";

return (
`Verify that your environment is configured according to the system requirements described at\n` +
`https://docs.nativescript.org/environment-setup.html${anchor}.`
`https://docs.nativescript.org/setup/${os}${anchor}.`
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/doctor/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export class Constants {
Constants.IOS_PLATFORM_NAME,
];
public static SYSTEM_REQUIREMENTS_LINKS =
"https://docs.nativescript.org/environment-setup.html";
"https://docs.nativescript.org/setup";
public static INFO_TYPE_NAME = "info";
public static WARNING_TYPE_NAME = "warning";

Expand Down